-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tenants UI #8015
Tenants UI #8015
Conversation
agriffard
commented
Dec 15, 2020
•
edited
Loading
edited
- Badge state: icon + text
- Buttons icon with tooltips
- Open external link
- Filter on state click
- Display url host (can have multiple domains)
- Database and Recipe badges
- Vertically align description with title
It was bigger at the begging ;) |
Try the state filters you will see that there is something to fix when no result is found. |
I don't think we should be using dots w/colors to indicate things. This applies more to the admin listing, but the patterns should be similar everywhere. I think we should be using coloured icons to represent states. It's gone a little too minimilist to get good quick readability. So suggestion is same colors, apply an icon to the color scheme. Example from devops. Ticks and Crosses Second suggestion. The buttons are quite small. A little bigger maybe? |
Prefer the tags w/badges 👍 (it helps keep the ui extensible easier as well) Think the Open action was better on the right Maybe not bold text is better for the actions Whats the lowercase a mean? |
lowercase a is the tenant description written quickly like asdf |
4px margin added. |
Ok for the margin. |
Ok I like it |
Maybe some work on the badges colors. I'm trying badge-secondary and font color white. It works on both darkmode and lightmode. But what you did works too. It's just really light. |
The disable tenant button requires a confirm modal. |
All list UIs aren't moving this "icon" based direction are they? Personally I am not a fan of too many icons for actions as they require interpretation by the user. If so can you apply the icons via a class applied to the button rather than inserting the icon markup into the button itself... this way those that want to can remove the icons via CSS rather than having to use a view in our theme to override Also for a saas installation are you really going to have different tenants on different database types - seems unnecessary? |
@scleaver Icons have a Bootstrap tooltip with the same text they used to have. |
src/OrchardCore.Modules/OrchardCore.Tenants/Views/Admin/Index.cshtml
Outdated
Show resolved
Hide resolved
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Tenants/Views/Admin/Index.cshtml